Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Czech based on the Launchpad Languages. #8853

Closed
ahadda5 opened this issue May 2, 2021 · 5 comments · Fixed by #8861
Closed

Support Czech based on the Launchpad Languages. #8853

ahadda5 opened this issue May 2, 2021 · 5 comments · Fixed by #8861
Assignees

Comments

@ahadda5
Copy link
Contributor

ahadda5 commented May 2, 2021

🚀 Feature Request

Description

Launchpad supported languages have been updated recently on Apr 12.

Describe the solution you'd like

2 weeks prior Prysm enhanced its web backend ,Part of #8664 , by supporting bip39 Mnemonic language in recovering their wallet from a mnemonic.
Currently supported languages in Bip39 are: English, chinese_simplified, chinese_traditional , French, Italian , Japanese , Korean, Spanish

New list: Chinses simplified, Czech, English, Italian, Korean, Spanish, French , Greek, Indonesian, Portuguese, Romanian, Arabic, German, Japanese, Turkish.

Both the CLI and web have to be up-to-date with the Launchpad language support.

Describe alternatives you've considered

None. Maintain the status quo.

@ahadda5
Copy link
Contributor Author

ahadda5 commented May 2, 2021

If the Prysm team approves the feature I can take this one.

@rkapka
Copy link
Contributor

rkapka commented May 3, 2021

@ahadda5 Assigned :)

@ahadda5
Copy link
Contributor Author

ahadda5 commented May 3, 2021

Well the Launchpad list set is inclusive of the bip39 except the Chinese(simplified vs traditional). Should we maintain traditional? I know @rauljordan has Chinese knowledge so maybe he can help?

@rauljordan
Copy link
Contributor

Yes we should maintain traditional @ahadda5 as they have a different corpus and the characters are different

@ahadda5 ahadda5 changed the title Support the recently added Launchpad Languages. Support Czech based on the Launchpad Languages. May 4, 2021
@ahadda5
Copy link
Contributor Author

ahadda5 commented May 4, 2021

We are limited with what bip39 offers. Portuguese can be added to the go library. Tracking this issue
For now Czech is missing from Prysm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants