Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undiscovered peers when listing peers #8882

Merged
merged 2 commits into from
May 11, 2021
Merged

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented May 11, 2021

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Follow-up to #8881. Makes sure undiscovered peers can be listed without causing a runtime panic.

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@rkapka rkapka added Ready For Review API Api related tasks labels May 11, 2021
@rkapka rkapka requested a review from a team as a code owner May 11, 2021 09:56
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #8882 (74fb383) into develop (8fe26e7) will decrease coverage by 0.10%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #8882      +/-   ##
===========================================
- Coverage    60.75%   60.65%   -0.11%     
===========================================
  Files          527      527              
  Lines        37112    37224     +112     
===========================================
+ Hits         22549    22578      +29     
- Misses       11332    11410      +78     
- Partials      3231     3236       +5     

@rkapka rkapka merged commit ddab82e into develop May 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the undiscovered-peer branch May 11, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants