regenerate ssz types w/ variable-len bounds checks #8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the code in this PR: ferranbt/fastssz#45
kasey
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #8936 +/- ##
===========================================
- Coverage 60.95% 60.84% -0.11%
===========================================
Files 530 531 +1
Lines 37488 37738 +250
===========================================
+ Hits 22849 22960 +111
- Misses 11366 11493 +127
- Partials 3273 3285 +12 |
kasey
changed the title
rauljordan
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This updates the generated ssz unmarshaling logic with a fix for ferranbt/fastssz#44
Which issues(s) does this PR fix?
Fixes #8935
Other notes for review
Please be sure to merge the fastssz changes [1] and bump the pinned version in go.mod before merging this generated code, because the generated code uses a new error type, also included in the fastssz PR.
[1] ferranbt/fastssz#45