Add missing finality spec tests #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
previously approved these changes
May 25, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8939 +/- ##
========================================
Coverage 60.85% 60.86%
========================================
Files 529 529
Lines 37368 37368
========================================
+ Hits 22742 22743 +1
Misses 11366 11366
+ Partials 3260 3259 -1 |
nisdas
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following missing finality spec tests, not sure when/how it got missed
https://github.com/ethereum/eth2.0-spec-tests/tree/v1.1.0-alpha.3/tests/minimal/phase0/finality/finality/pyspec_tests