ETH2 APIs: Implement Validator Status support #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
May 25, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8940 +/- ##
===========================================
+ Coverage 60.88% 60.92% +0.04%
===========================================
Files 529 529
Lines 37368 37418 +50
===========================================
+ Hits 22750 22798 +48
+ Misses 11358 11353 -5
- Partials 3260 3267 +7 |
rkapka
reviewed
May 26, 2021
| } | ||
| } | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
0 is ValidatorStatus_PENDING_INITIALIZED, which is an incorrect value to return. We should return an error instead.
| Status: []ethpb.ValidatorStatus{ethpb.ValidatorStatus_PENDING_INITIALIZED, ethpb.ValidatorStatus_EXITED_UNSLASHED}, | ||
| }) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, 4 /* 4 exited */, len(resp.Data)) |
There was a problem hiding this comment.
I think the comment is incorrect.
There was a problem hiding this comment.
Its correct, at the epoch there are 4 validators that fir the exit status criteria.
| validator *ethpb.Validator | ||
| epoch types.Epoch | ||
| } | ||
| tests := []struct { |
There was a problem hiding this comment.
You forgot about pending_queued
| validator *ethpb.Validator | ||
| epoch types.Epoch | ||
| } | ||
| tests := []struct { |
There was a problem hiding this comment.
You forgot about pending_queued
rkapka
reviewed
May 26, 2021
| case ethpb.ValidatorStatus_WITHDRAWAL_POSSIBLE, ethpb.ValidatorStatus_WITHDRAWAL_DONE: | ||
| return ethpb.ValidatorStatus_WITHDRAWAL | ||
| } | ||
| return 0 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR fixes #8901 and is part of #7510. This PR adds validator status enum support to your API, allowing the api to return validators status, and allowing filtering the validator set based on their status.