Add Better Zero Key Checks #9022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #9022 +/- ##
===========================================
- Coverage 60.90% 60.88% -0.02%
===========================================
Files 531 531
Lines 37609 37607 -2
===========================================
- Hits 22905 22897 -8
- Misses 11430 11437 +7
+ Partials 3274 3273 -1 |
shared/bls/blst/secret_key.go
Outdated
| return s.p.Equals(zeroKey) | ||
| // IsZero checks if the secret key is a zero key. This returns | ||
| // an uint8 which can either be 0 or 1. | ||
| func IsZero(sKey []byte) uint8 { |
There was a problem hiding this comment.
Why not return a boolean?
prestonvanloon
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review