Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable No Freelist Sync In Backups #9069

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Disable No Freelist Sync In Backups #9069

merged 1 commit into from
Jun 21, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 21, 2021

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • This can lead to extremely long recovery times when running a node from a fresh backup as bolt has to traverse
    through all the buckets in the db to rebuild the freelist.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner June 21, 2021 08:48
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #9069 (96b819e) into develop (6e42f1b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #9069      +/-   ##
===========================================
+ Coverage    60.26%   60.27%   +0.01%     
===========================================
  Files          541      541              
  Lines        38644    38643       -1     
===========================================
+ Hits         23289    23293       +4     
+ Misses       12006    12002       -4     
+ Partials      3349     3348       -1     

@rkapka rkapka merged commit 9ee086f into develop Jun 21, 2021
@rkapka rkapka deleted the fixBackup branch June 21, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants