Fix a few bugs in the API #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
kasey,
jmozah and
terencechain
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9099 +/- ##
===========================================
- Coverage 60.21% 60.13% -0.09%
===========================================
Files 542 542
Lines 38730 38735 +5
===========================================
- Hits 23321 23293 -28
- Misses 12049 12082 +33
Partials 3360 3360 |
terencechain
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fixes a few API bugs:
/eth/v1/beacon/states/{state_id}/validatorsand/eth/v1/beacon/states/{state_id}/validators/{validator_id}endpoints were incorrectly registered/eth/v1/node/peersendpoint didn't have query params registered/eth/v1/node/peersshould return an empty array when no matching peers are foundWhich issues(s) does this PR fix?
N/A
Other notes for review
N/A