Make Eth APIs flag name implementation agnostic #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
jmozah,
rauljordan and
prestonvanloon
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9112 +/- ##
===========================================
+ Coverage 59.92% 60.20% +0.28%
===========================================
Files 543 543
Lines 39212 38723 -489
===========================================
- Hits 23496 23313 -183
+ Misses 12357 12053 -304
+ Partials 3359 3357 -2 |
rauljordan
approved these changes
Jun 28, 2021
|
Great idea to save us from technical debt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
api-middleware-portis the current name of the flag which specifies the port to serve HTTP JSON conforming to the official Eth2 APIs. API Middleware is an implementation detail and the flag name should rather describe the functionality. This PR renames it toeth-api-port. If we replace the API Middleware with something else in the future, the flag name will still be up-to-date.