Do not require a handler function in the gateway #9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
kasey,
jmozah and
rauljordan
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9264 +/- ##
===========================================
- Coverage 60.88% 60.85% -0.04%
===========================================
Files 550 550
Lines 39413 39411 -2
===========================================
- Hits 23998 23983 -15
- Misses 11914 11935 +21
+ Partials 3501 3493 -8 |
rauljordan
approved these changes
Jul 23, 2021
rkapka
added a commit
that referenced
this pull request
Jul 26, 2021
prestonvanloon
pushed a commit
that referenced
this pull request
Jul 30, 2021
* Do not require a handler function in the gateway * test fix Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> (cherry picked from commit be82c87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Passing
h.ServeHTTP(w, req)did not turn out to be a sensible default handler as it causes an infinite loop. A better approach is to make the handler optional.Which issues(s) does this PR fix?
Fixes #9246
Other notes for review
N/A