Treat Post & Pre-ChainStart Validators Equally in Assignments Fetching #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
prestonvanloon,
nisdas,
0xKiwi and
terencechain
terencechain
approved these changes
Mar 26, 2019
0xKiwi
approved these changes
Mar 26, 2019
Co-Authored-By: rauljordan <raul@prysmaticlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
+ Coverage 69.54% 69.61% +0.07%
==========================================
Files 112 112
Lines 8632 8587 -45
==========================================
- Hits 6003 5978 -25
+ Misses 2012 1996 -16
+ Partials 617 613 -4 |
| @@ -39,7 +41,7 @@ func (db *BeaconDB) SaveValidatorIndexBatch(pubKey []byte, index int) error { | |||
| // ValidatorIndex accepts a public key and returns the corresponding validator index. | |||
| func (db *BeaconDB) ValidatorIndex(pubKey []byte) (uint64, error) { | |||
| if !db.HasValidator(pubKey) { | |||
| return 0, fmt.Errorf("validator %#x does not exist", pubKey) | |||
| return 0, status.Error(codes.NotFound, fmt.Sprintf("validator %#x does not exist", pubKey)) | |||
There was a problem hiding this comment.
The db package shouldn't return a gRPC error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1586
Description
Write why you are making the changes in this pull request
Currently our validator client treats post-chainstart validators differently than pre-chainstart ones. However, they should be treated equally as eventually they will get activated and will be receiving assignments.
Write a summary of the changes you are making
We start querying for assignments from the canonical head of the beacon node we are connected to. If we have a "not found" error code, we simply keep listening as if the validator is activated, the assignments will eventually come.