Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

Remove check platform. #66

Closed
phongdaohp opened this issue Feb 25, 2015 · 4 comments
Closed

Remove check platform. #66

phongdaohp opened this issue Feb 25, 2015 · 4 comments

Comments

@phongdaohp
Copy link

Dear Developer.

I check your code I saw line code check platform "isWin", I think it is unnecessary because your module can working in linux platform but when I install in linux I must fix your code to compatible.

Can you remove this lines below in next version?

// Check if win.
var isWin = /^win/.test(process.platform);
if (isWin) { opt = [process.env.PYTHON || 'python', [file].concat(args)]; }

and change it to

opt = [process.env.PYTHON || 'python', [file].concat(args)];

Best regard.

Phong Dao

@prabhu
Copy link

prabhu commented Feb 26, 2015

Can you send a PR?

@fent fent closed this as completed in 833d281 Feb 26, 2015
@phongdaohp
Copy link
Author

Can you update fixed on npm nodejs?

@fent
Copy link
Collaborator

fent commented Feb 27, 2015

Published new version.

@phongdaohp
Copy link
Author

Thanks fent,

I have question for you. How can I handle error in process download avoid crash my program?
Best regard.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants