PossiblyUnusedParam

[bohdanmoshchenko]

With Symfony 6.3.1, vimeo/psalm 5.13.0 and doctrine/doctrine-bundle 2.10.0

ERROR: PossiblyUnusedParam - src/User/Repository/UserTokenRepository.php:16:49 - Param psalm/psalm-plugin-symfony#1 is never referenced in this method (see https://psalm.dev/134)
public function __construct(ManagerRegistry $registry)
ERROR: PossiblyUnusedParam - src/User/Repository/UserTokenRepository.php:24:49 - Param psalm/psalm-plugin-symfony#1 is never referenced in this method (see https://psalm.dev/134)
public function findOneByTypeAndHash(string $type, string $hash): ?UserToken
ERROR: PossiblyUnusedParam - src/User/Repository/UserTokenRepository.php:24:63 - Param psalm/psalm-plugin-symfony#2 is never referenced in this method (see https://psalm.dev/134)
public function findOneByTypeAndHash(string $type, string $hash): ?UserToken

CODE:

<?php

declare(strict_types=1);

namespace App\User\Repository;

use App\User\Entity\UserToken;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

/**
 * @extends ServiceEntityRepository<UserToken>
 */
class UserTokenRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, UserToken::class);
    }

    /**
     * @psalm-param value-of<UserToken::AVAILABLE_TYPES> $type
     */
    public function findOneByTypeAndHash(string $type, string $hash): ?UserToken
    {
        return $this->findOneBy(['type' => $type, 'hash' => $hash]);
    }
}

[weirdan]

What version of the doctrine bundle (where ServiceEntityRepository comes from) do you have?

[bohdanmoshchenko]

@weirdan doctrine/doctrine-bundle 2.10.0

[weirdan]

Thanks. My guess is that Psalm is confused with a conditional class definition here: https://github.com/doctrine/DoctrineBundle/blob/2.10.x/Repository/ServiceEntityRepository.php

Do you also use https://github.com/psalm/psalm-plugin-doctrine (you most likely should)?

[bohdanmoshchenko]

@weirdan Yes. I use it too.

[weirdan]

@bohdanmoshchenko I believe this issue belongs here, as it's doctrine-specific.

[MihailSerov]

you can temporally fix it by this:

<?php

use Doctrine\Bundle\DoctrineBundle\Repository\LazyServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

/**
 * @template T of object
 * @template-extends LazyServiceEntityRepository<T>
 *
 * @psalm-suppress InternalClass
 */
class ServiceEntityRepository extends LazyServiceEntityRepository
{
    /**
     * @psalm-param class-string $entityClass
     *
     * @psalm-suppress InternalMethod
     */
    public function __construct(ManagerRegistry $registry, string $entityClass)
    {
        parent::__construct($registry, $entityClass);
    }
}

class MyRepository extends ServiceEntityRepository
{
}