New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ruby < 2.3 #11

Open

sshaw opened this issue Jan 31, 2020 · 1 comment

sshaw commented Jan 31, 2020 •

edited

Loading

Hi, your gem supports Rails >= 4.1 (🎉) but since you use the safe navigation operator (&.) one must have Ruby >= 2.3.

I understand that 2.3 is EOL'd but unfortunately that does not mean systems will stop using these versions.

I can put together a PR for this is you're interested. I see no downside.

The text was updated successfully, but these errors were encountered:

Author

sshaw commented Jan 31, 2020

Though actually User Agent Parser requires 2.4. You'd have to change gem requirement to 2.4.1 to support Ruby <= 2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment