Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black is changing string output #1338

Closed
ghost opened this issue Apr 9, 2020 · 3 comments
Closed

Black is changing string output #1338

ghost opened this issue Apr 9, 2020 · 3 comments
Labels
T: bug Something isn't working

Comments

@ghost
Copy link

ghost commented Apr 9, 2020

Black is changing string output.

Here's a small test case:

raise ValueError('"{}" is an invalid base58 encoded'
                 'character'.format('l'))

Becomes:

raise ValueError('"{}" is an invalid base58 encoded' "character".format("l"))

Environment (please complete the following information):

  • Version: 19.10b0 and master
  • OS and Python version: Linux / Python 3.7.3

Does this bug also happen on master? To answer this, you have two options:

  1. Use the online formatter at https://black.now.sh/?version=master, which will use the
    latest master branch. https://black.now.sh/?version=master&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4ACfAHpdAD2IimZxl1N_WmXTfF4pk2diOB2w7CF3u5csmBIqM4tZ28bz-Wsjw8BMMi3lwqytjqgVBMVZiUacQNqGZGmn05W4ih2sBeTwYw0rsxRWBiFpcmw2i3q879NrXW32Ni69xWm_UcfshWKDsKmY5ZLH_kSJlcUumQkQtenWAAAACm-bFP1IlaQAAZYBoAEAAAF7o3mxxGf7AgAAAAAEWVo=
@ghost ghost added the T: bug Something isn't working label Apr 9, 2020
This was referenced Apr 9, 2020
@ofek
Copy link
Contributor

ofek commented Apr 9, 2020

#26

@JelleZijlstra
Copy link
Collaborator

It's the same string at runtime. The formatting is definitely not great, but we already have #26 to track that.

@ghost
Copy link
Author

ghost commented Apr 10, 2020

Ah, gotcha. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants