Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL ERROR: Black produced different code on the second pass of the formatter. String literal concatentation #2035

Closed
kevdowney opened this issue Mar 12, 2021 · 1 comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working

Comments

@kevdowney
Copy link

Describe the bug
Multi-line string literal concatenation causes problems. See python docs

Bad

        command = self.manifest_file_path("out/{}".format(self.get_binary_type("roles"))) + "\
                --input \"{}\" \
                --cluster-name \"{}\" \
                --region \"{}\"".format(self.manifest_file_path("configs/roles-config.yaml"), cluster_name,
                                        cluster_region)

Fixed

        command = self.manifest_file_path(
            "out/{}".format(self.get_binary_type("roles"))
        ) + '--input "{}" --cluster-name "{}" --region "{}"'.format(
            self.manifest_file_path("configs/roles-config.yaml"),
            cluster_name,
            cluster_region,
        )
+++ second pass
@@ -229,20 +229,19 @@ 
-        command = (
-            self.manifest_file_path("out/{}".format(self.get_binary_type("roles")))
-            + '\
+        command = self.manifest_file_path(
+            "out/{}".format(self.get_binary_type("roles"))
+        ) + '\
                 --input "{}" \
                 --cluster-name "{}" \
                 --region "{}"'.format(
-                self.manifest_file_path("configs/roles-config.yaml"),
-                cluster_name,
-                cluster_region,
-            )
+            self.manifest_file_path("configs/roles-config.yaml"),
+            cluster_name,
+            cluster_region,

To Reproduce Steps to reproduce the behavior:

  1. Take this file '...'
  2. Run Black on it with these arguments '....'
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • Version: [e.g. master]
  • OS and Python version: [e.g. Linux/Python 3.7.4rc1]

Does this bug also happen on master? To answer this, you have two options:

  1. Use the online formatter at https://black.now.sh/?version=master, which will use the
    latest master branch.
  2. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .;
    • make sure it's sane by running python -m unittest; and
    • run black like you did last time.

Additional context Add any other context about the problem here.

@kevdowney kevdowney added the T: bug Something isn't working label Mar 12, 2021
@ichard26 ichard26 added the C: unstable formatting Formatting changed on the second pass label Mar 12, 2021
@ichard26 ichard26 added the R: duplicate This issue or pull request already exists label Apr 25, 2021
@ichard26
Copy link
Collaborator

Hello!

All reproduction cases in this issue format without error on master. The fixing commit was 8672af3 from PR GH-2126. I'll be marking this issue as a duplicate of GH-1629 since that's what GH-2126 aimed to fix and it's highly likely this issue falls under GH-1629.

Since we use the issue tracker as a reflection of what's on master, I'll be closing this issue. If you have any issues, especially with the new (but stable) output, please open a new issue. Oh and the fix should be available in a published release soon, see GH-2125 for more info.

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: unstable formatting Formatting changed on the second pass R: duplicate This issue or pull request already exists T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants