Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer deprecation plan #2821

Closed
JelleZijlstra opened this issue Jan 29, 2022 · 2 comments · Fixed by #2924
Closed

Primer deprecation plan #2821

JelleZijlstra opened this issue Jan 29, 2022 · 2 comments · Fixed by #2924
Assignees
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Comments

@JelleZijlstra
Copy link
Collaborator

I removed black-primer from CI in #2809 because it was causing annoying and useless CI failures, but kept the code around to avoid unnecessary changes around the stable release. I'd like to keep it around for at least one release that marks it as formally deprecated.

How long should we keep it? Is there any reason to keep it around for longer?

Also, removing the primer tests lost us some platform coverage, because black-primer used to run on lots of OS and Python version combinations and diff-shades doesn't. I'm not too convinced that was helpful, because we already run our unit tests on lots of configurations, but if we wanted we could add back a bigger test matrix.

@JelleZijlstra JelleZijlstra added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label Jan 29, 2022
@felix-hilden
Copy link
Collaborator

Can't think of a reason. A one-release deprecation sounds good, and git'll have the code in store.

@cooperlees
Copy link
Collaborator

cooperlees commented Jan 29, 2022

I’ll take this and move it to cooperlees/black-primer after the release and if people want it they can install it from there …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants