Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI fail if a PR is targeted to "stable" #3379

Closed
JelleZijlstra opened this issue Nov 10, 2022 · 0 comments
Closed

Make CI fail if a PR is targeted to "stable" #3379

JelleZijlstra opened this issue Nov 10, 2022 · 0 comments
Assignees
@ichard26
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Comments

@JelleZijlstra
Copy link
Collaborator

#3378 was just accidentally merged into the stable branch, which should only be updated after releases. There appears to be no way to use branch protection rules to disallow such PRs (community/community#13836). To prevent similar mistakes in the future, we should have some check on PRs that fails if the target isn't main.
@JelleZijlstra JelleZijlstra added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label Nov 10, 2022
@ichard26 ichard26 self-assigned this Nov 10, 2022
@calumy calumy mentioned this issue Dec 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichard26 ichard26

Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @ichard26