Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8-commas support #551

Closed
yutkin opened this issue Oct 5, 2018 · 4 comments
Closed

Flake8-commas support #551

yutkin opened this issue Oct 5, 2018 · 4 comments

Comments

@yutkin
Copy link

yutkin commented Oct 5, 2018

Is there any plans to conform flake8-commas?

@JelleZijlstra
Copy link
Collaborator

I'm not familiar with this tool, but glancing at the README it should mostly already match Black's behavior. What specific change are you looking for?

@yutkin
Copy link
Author

yutkin commented Oct 5, 2018

After usage of Black, I still have several warnings from flake8-commas (C812, C815, C816).
For example, line 546 causes C812 warning.

545     fill_data = missing_values_filling_needed(
546         get_filters(report_query.get("metrics", []))
547     )

@asottile
Copy link
Contributor

I think the idea with black is that you'd remove flake8-commas because black will automatically rewrite your code to avoid the things it would lint for.

The one disagreement between the two tools is that black will not put a comma on single line calls (an aside: this is also the only inconsistency between black and add-trailing-comma)

@JelleZijlstra
Copy link
Collaborator

Doesn't sound like this is currently actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants