Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CONFIG_ARGS in Metadata #179

Closed
JeffersGlass opened this issue Apr 18, 2024 · 3 comments · Fixed by #180
Closed

Include CONFIG_ARGS in Metadata #179

JeffersGlass opened this issue Apr 18, 2024 · 3 comments · Fixed by #180

Comments

@JeffersGlass
Copy link
Contributor

It would be useful to have the information from the CONFIG_ARGS variable in the metadata for a benchmark file.

The use case is: determining whether two benchmarks were built from the same Python commit and built with the same options (specifically with regards to the new JIT and PGO).

For more context - I am experimenting with paralleling pyperformance across several machines, and for efficiency I am caching several builds of Python on each machine. In order to generate useful comparison data between many different benchmark files, it's useful to extract the commit, JIT and PGO status from the benchmark files themselves.

If there's a better way to determine that data, I'd be open to that.

I have a branch which adds in this info, if it would be useful to submit a PR.

@vstinner
Copy link
Member

Do you want to propose a PR for that?

@JeffersGlass
Copy link
Contributor Author

Sure! I've opened #180, which is linked to this issue.

@vstinner
Copy link
Member

Fixed by 9a99cbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants