-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract_cookies_to_jar requires a response with _original_response #1534
Comments
This probably doesn't help but a few things:
I also wouldn't be opposed to documenting the method, but for the most part, I don't see this being a bug. Maybe @Lukasa or @kennethreitz |
Heh, @kennethreitz is the one who told me to file it :) I actually have it mocked and it's pretty janky. Simple fix for upstream though and the FWIW: dstufft/pip@aba6f37 |
The fix is simple without a doubt and since it seems @kennethreitz seems okay with it, I'll put together a PR with it. That said, the best workaround is not that janky frankly but you're right in that it shouldn't be necessary. My project needs it though :/ |
While attempting to make a
LocalFSAdapter()
which handlesfile://
urls I discovered that the response objects need to have an_original_response
attribute or it bombs out at https://github.com/kennethreitz/requests/blob/master/requests/cookies.py#L113.The text was updated successfully, but these errors were encountered: