Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit concerns in #2244 #2287

Closed
sigmavirus24 opened this issue Oct 17, 2014 · 2 comments
Closed

Revisit concerns in #2244 #2287

sigmavirus24 opened this issue Oct 17, 2014 · 2 comments

Comments

@sigmavirus24
Copy link
Contributor

See https://github.com/kennethreitz/requests/pull/2244 for more context:

Specific concerns are:

  • Should redirects handled by the cache count against the max number of redirects? (e.g., if we set a max of 30 and find 2 redirects in the cache, the max number of redirects a user could encounter after that would be 28)
  • Should history be some-how generated by the redirect cache? (i.e., should we be making responses and adding them to the final response's history?)
  • Should a separate error be raised for the case where there's a loop in the cache? (When documented this would help the user realize they're stuck in a cached loop and that they may want to clear it to retry using the live site. Note: this also affects the API of Session#resolve_redirects.)
@sigmavirus24
Copy link
Contributor Author

@Lukasa is it still worth keeping this open?

@Lukasa
Copy link
Member

Lukasa commented Apr 7, 2015

I still hate the redirect cache, but I think we should talk about it at PyCon. In particular, we should talk about whether we should yank it out and instruct people to use CacheControl instead.

@Lukasa Lukasa closed this as completed Apr 7, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants