-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status Code 425 named incorrectly #6584
Comments
I would merge a change to add that to the type definition. Keep in mind unordered was in wide use before that rfc though which is why it has that definition. I doubt anyone is using it from us but we can't remove it. |
Implementing this in an upcoming PR. |
Here is a PR with relevant changes that I believe are backwards compatible and generalizable. Could you take a look and give your initial thoughts? @nateprewitt |
Resolving now that #6592 is merged. |
HTTP status code 425 is defined as "too early". While the defining RFC defines the code in the context of TLS, I regularly find APIs that use this status code to indicate to a client that an asynchronous job that has been started is still being processed, so the result can not yet be provided.
requests.status_codes however doesn't know the reason "too early", and instead calls 425 "unordered_collection" and "unordered". I believe, this is a bug.
The defendent: https://github.com/psf/requests/blob/main/src/requests/status_codes.py#L82
I call to the witness stand:
Expected Result
Actual Result
Reproduction Steps
System Information
The text was updated successfully, but these errors were encountered: