Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

When using Where filter transforms, every parameter is being included when the SQL string is generated. #51

Open
aidapsibr opened this issue Aug 15, 2016 · 3 comments

Comments

@aidapsibr
Copy link
Collaborator

Every parameter is being included when the SQL string is generated. This causes the SQL string to be longer than necessary, bloating the plan cache, and potentially requiring more effort when hunting for a plan. It also makes reading and using the output SQL more cumbersome.

@aidapsibr
Copy link
Collaborator Author

This MAY be solvable by the where filter removing NULL parameters that are not explicitly ignored by the filter transform.

@porterchris
Copy link

That is where I think it needs to happen. There is an iteration for implicit and explicit parameters. The check should be in the implicit parameter list. It could potentially in the explicit parameter list but I think that might create more problems than it would help to solve.

@aidapsibr
Copy link
Collaborator Author

Currently the parameter is ignored by the Where Filter factory, but the parameter is not removed from the query parameters. That is the change that would be made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants