Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From vs Into #187

Closed
dalcde opened this issue Jan 30, 2020 · 2 comments
Closed

From vs Into #187

dalcde opened this issue Jan 30, 2020 · 2 comments

Comments

@dalcde
Copy link
Contributor

dalcde commented Jan 30, 2020

With Rust 1.41, there is no reason to implement Into instead of From. Should the code generator always generate From instead of Into?

@psychon
Copy link
Owner

psychon commented Jan 30, 2020

You are referring to the following, right?

https://github.com/rust-lang/rust/blob/master/RELEASES.md

If so, that would mean bumping the minimum required rust version. It is currently 1.37.0.

@dalcde
Copy link
Contributor Author

dalcde commented Jan 30, 2020

I just realized that all current instances of impl Into can be replaced with impl From even without the recent change. Submitting PR for that.

@dalcde dalcde closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants