We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With Rust 1.41, there is no reason to implement Into instead of From. Should the code generator always generate From instead of Into?
Into
From
The text was updated successfully, but these errors were encountered:
You are referring to the following, right?
https://github.com/rust-lang/rust/blob/master/RELEASES.md
You can now pass type parameters to foreign items when implementing traits. E.g. You can now write impl<T> From<Foo> for Vec<T> {}.
impl<T> From<Foo> for Vec<T> {}
If so, that would mean bumping the minimum required rust version. It is currently 1.37.0.
Sorry, something went wrong.
I just realized that all current instances of impl Into can be replaced with impl From even without the recent change. Submitting PR for that.
impl Into
impl From
No branches or pull requests
With Rust 1.41, there is no reason to implement
Into
instead ofFrom
. Should the code generator always generateFrom
instead ofInto
?The text was updated successfully, but these errors were encountered: