Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in GetHumRatioFromSpecificHum within psychrolib.c #59

Closed
BingWangUS opened this issue Apr 9, 2020 · 6 comments · Fixed by #61
Closed

Typo in GetHumRatioFromSpecificHum within psychrolib.c #59

BingWangUS opened this issue Apr 9, 2020 · 6 comments · Fixed by #61
Labels

Comments

@BingWangUS
Copy link

BingWangUS commented Apr 9, 2020

Typo in the warning message at line 640.

@dmey
Copy link
Contributor

dmey commented Apr 9, 2020

Typo in the warning message at line 640.

Sorry but I do not see it -- can you be a bit more specific please?

@BingWangUS
Copy link
Author

Sure. Here it is:

ASSERT (SpecificHum >= 0.0 && SpecificHum < 1.0, "Specific humidity is outside range [0,1[")

last one should be ] instead of [.

@dmey
Copy link
Contributor

dmey commented Apr 10, 2020

last one should be ] instead of [.

It looks OK to me, the bracket [ is used to indicate that that side of the interval is open. --the 1 is excluded. Is this unclear to you? Perhaps we could use a more standard notation and use parenthesis to indicate open intervals -- @didierthevenard would you be OK with that?

@BingWangUS
Copy link
Author

Oh thanks for explaining that. Then all good.

@didierthevenard
Copy link
Contributor

I am okay with changing it to the more standard notation. The [0,1[ notation comes from my education because that's how French mathematicians represent open intervals, but I came to realize that this is not how the rest of the world does it, [0,1) is used in the US (and in the UK?). Both notations are acceptable as laid out here: https://en.wikipedia.org/wiki/ISO_31-11. Use whatever will be understood by the greatest number of people.

@dmey
Copy link
Contributor

dmey commented Apr 10, 2020

Personally, I am familiar with both of them so I don't really mind but perhaps using parenthesis would make mote understandable to more people!? I have addressed this in #61 -- if that looks OK, please approve and will merge it in otherwise we can leave it as is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants