-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in GetHumRatioFromSpecificHum within psychrolib.c #59
Comments
Sorry but I do not see it -- can you be a bit more specific please? |
Sure. Here it is: Line 640 in f3a2891
last one should be ] instead of [. |
It looks OK to me, the bracket [ is used to indicate that that side of the interval is open. --the 1 is excluded. Is this unclear to you? Perhaps we could use a more standard notation and use parenthesis to indicate open intervals -- @didierthevenard would you be OK with that? |
Oh thanks for explaining that. Then all good. |
I am okay with changing it to the more standard notation. The [0,1[ notation comes from my education because that's how French mathematicians represent open intervals, but I came to realize that this is not how the rest of the world does it, [0,1) is used in the US (and in the UK?). Both notations are acceptable as laid out here: https://en.wikipedia.org/wiki/ISO_31-11. Use whatever will be understood by the greatest number of people. |
Personally, I am familiar with both of them so I don't really mind but perhaps using parenthesis would make mote understandable to more people!? I have addressed this in #61 -- if that looks OK, please approve and will merge it in otherwise we can leave it as is... |
Typo in the warning message at line 640.
The text was updated successfully, but these errors were encountered: