Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reload task failed log appender xml file to use same format as appender file for "reload aborted" #126

Closed
mountaindude opened this issue Feb 10, 2021 · 1 comment
Milestone

Comments

@mountaindude
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Right now "reload failed" and "reload aborted" use two slightly different mechanisms for triggering in the XML log appender files.

"Reload aborted" generates a UDP message like this:
/scheduler-reload-aborted/;%hostname;%property{TaskName};%property{AppName};%property{User};%property{TaskId};%property{AppId};%date;%level%property{ExecutionId};%message

"Reload failed" generates a message like this:
%hostname;%property{TaskName};%property{AppName};%property{User};%property{TaskId};%property{AppId};%date;%level%property{ExecutionId};%message

This is for historical reasons - when Butler was created "reload failed" was the only message, but as there was a need to detect different patterns in the log files (and send different UDP messages!), the first field in the UDP message was designated as an identifier field, telling what kind of event the message contained.

Describe the solution you'd like

  1. Make "reload failed" UDP message look like this:
    /scheduler-reload-failed/;%hostname;%property{TaskName};%property{AppName};%property{User};%property{TaskId};%property{AppId};%date;%level%property{ExecutionId};%message
  2. Keep the old format for "reload failed" UDP messages as the default one, if there is no match on the first field of the message. This will minimize the impact for systems that use the older UDP message format.
@mountaindude mountaindude added this to the 4.4 milestone Feb 10, 2021
@mountaindude mountaindude changed the title Change reload task failed log appender xml file to use same format as appender file for "reload abortet" Change reload task failed log appender xml file to use same format as appender file for "reload aborted" Feb 12, 2021
@mountaindude mountaindude modified the milestones: 4.4, 5.0 Feb 14, 2021
@mountaindude
Copy link
Collaborator Author

Included in coming 5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant