Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sanity checking of task IDs in start task API #319

Closed
mountaindude opened this issue Dec 13, 2021 · 0 comments · Fixed by #338
Closed

Better sanity checking of task IDs in start task API #319

mountaindude opened this issue Dec 13, 2021 · 0 comments · Fixed by #338
Milestone

Comments

@mountaindude
Copy link
Collaborator

mountaindude commented Dec 13, 2021

Is your feature request related to a problem? Please describe.
Improved existing feature.

If an invalid task ID (such as abc) is passed to the /v4/reloadtask/:taskId/start API, Butler will log an error:

image

Before trying to act on a task ID it should be sanity checked, for example that the format is actually a valid guid.

Test in two places:

  1. On Butler startup. Warn if an invalid task ID is found
  2. Whenever a task should be started using task IDs. Warn if an invalid task ID is found, then just drop it (don't try to use it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant