Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly confusing log message when sending events/logs to New Relic #571

Closed
mountaindude opened this issue Oct 10, 2022 · 0 comments · Fixed by #601 or #981
Closed

Slightly confusing log message when sending events/logs to New Relic #571

mountaindude opened this issue Oct 10, 2022 · 0 comments · Fixed by #601 or #981
Assignees
Labels
Milestone

Comments

@mountaindude
Copy link
Collaborator

Sending log/events to New Relic consists of several steps:

  1. Checking if rate limiting allows for log/event to be sent
  2. Sending the log/event, taking into account per-task configuration (which tasks that result in events/logs to be sent to NR etc)

Currently (v8.5.2) step 1 above outputs something like this for event and log, respectively:

info: TASK FAILED NEWRELIC: Rate limiting ok: Sending reload failure event to New Relic for task "Some task name"
info: TASK FAILED NEWRELIC: Rate limiting ok: Sending reload failure log entry to New Relic for task "Some task name"

Those messages should only mentioned that rate limiting passed, NOT that the event/log is being sent to NR. That is decided in later steps, which should have their own logging about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment