Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for accidental overwrite of server daemonSecret #24

Closed
DaneEveritt opened this issue Jan 9, 2016 · 1 comment
Closed

Potential for accidental overwrite of server daemonSecret #24

DaneEveritt opened this issue Jan 9, 2016 · 1 comment
Labels
bug Something that's not working as it's intended to be.

Comments

@DaneEveritt
Copy link
Member

The code below ends up changing the daemon secret depending on which user is viewing the server, which works as intended. However, there is the potential for accidentally overwriting the daemonSecret if we make a ->save() request off of the result from this class function.

if(!is_null($result)) {
    $result->daemonSecret = self::getUserDaemonSecret($result);
}
@DaneEveritt DaneEveritt added bug Something that's not working as it's intended to be. investigating labels Jan 9, 2016
@DaneEveritt
Copy link
Member Author

closed in 71e6d2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
None yet
Development

No branches or pull requests

1 participant