-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANNOUNCEMENT: Help testing the RxDB version 15 release #5155
Comments
Can you release a matching beta version for |
@adam-lynch This is done already. There is version |
Great new functionality that the full replication is no longer happening after migrating. |
Hi @voiddev90 the storage-migration plugin does not migrate your replication states. |
npm ERR! enoent ENOENT: no such file or directory, open '/var/www/html/rxdb/examples/vite-vanilla-ts/rxdb-local.tgz' - |
https://rxdb.info/releases/15.0.0.html - page not found |
|
The postinstall npm script in the examples should create the |
v15 made migrations public, which is great. I am currently using the beta version of v15, and all the APIs I'm using do not involve version differences. So, I'm thinking, since migrations are now public, why not also open up the disableVersionCheck function? Otherwise, migrations might not be very useful. The export function isDatabaseStateVersionCompatibleWithDatabaseCode(
databaseStateVersion: string,
codeVersion: string
): boolean {
if (!databaseStateVersion) {
return false;
}
if (
codeVersion.includes('beta') &&
codeVersion !== databaseStateVersion
) {
return false;
}
const stateMajor = databaseStateVersion.split('.')[0];
const codeMajor = codeVersion.split('.')[0];
if (stateMajor !== codeMajor) {
return false;
}
return true;
} // RxDB Premium v15 or newer:
import { disableVersionCheck } from 'rxdb-premium-old/plugins/shared';
disableVersionCheck(); From a developer experience perspective, disableVersionCheck should be built-in and optional because in most scenarios, developers won't encounter RxDB's underlying APIs, and there are no version differences at the data layer. I am a developer who uses RxDB for applications to a moderate extent. It would be great if upgrading RxDB versions could be done seamlessly. |
@1yasa It happened so often in the past that people had problems and reported them even when they have been already fixed. This mostly happened because the missed upgrading the correct rxdb-premium version along with their rxdb version. |
What I mean is, since the migration plugin has been made accessible to everyone, could the disableVersionCheck function also be made available? I understand your concerns, but those who can find this function are already aware of its usage and potential impacts. (Regarding the issue of database state damage, in practice, a dump backup of the database is always performed before executing database migration or modification operations, so this shouldn't be a problem.) |
@1yasa I think you are confusing the disableVersionCheck() from premium with the |
soga. |
@pubkey Do you have a new timeframe for when V15 will be released? |
@voiddev90 Mid next week. But only if there are no mid/big problems found. |
@voiddev90 I am sorry, there is something I have to refactor with index handling to clear the path for a server plugin that is planned for start of 2024. |
@pubkey Thanks for the update |
Just released |
Just released |
Just released version 15! Read more about the changes here |
RxDB version 15.0.0 is now it beta and you should help testing it so that you can later safely migrate to the new version.
RxDB v15 release notes: https://github.com/pubkey/rxdb/blob/master/docs-src/docs/releases/15.0.0.md
What should be tested
Especially the schema migration should be tested. What happens when you increase your schema versions and run the schema migration. Does everything work without errors? Does the replication continue from the correct checkpoints?
Also the EventReduce algorithm is now activated by default. Make sure that your observed queries still emit the correct results at the correct point in time.
How to test
You can find the latest
15.0.0-beta.XX
version here: https://github.com/pubkey/rxdb/releasesUpdate your package json with that rxdb-version and re-install your node_modules. Then you update all required code changes and test your application.
If you find any bugs, report them here or better, create a PR with a test case.
The new version will be in beta for about 4 weeks, then it will be released if no more bugs are found.
The text was updated successfully, but these errors were encountered: