-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate newer key
API method in place of the deprecated which
method
#211
Comments
Pinging @jywarren, @sashadev-sky, or @gauravano to mark this as an |
@rexagod ok cool! Did you look up if this is the new convention for keymaps? I know I said |
making a candidate until you get back to me on that. Also did you make these changes locally and everything still worked? |
@sashadev-sky I did look up the convention and compatibility of the |
@rexagod Looks good! Changing this to an FTO. I'll post it in the plots2 FTO page for you so people see it. Is the plan to update all of them through a bunch of FTOs? |
Can I claim this? |
@SteliosPhanartzis Yes all yours! |
Was the DistortableImage.Edit.js the only file that had the which method? |
@SteliosPhanartzis yes the only one that's currently in use. Don't worry about standardizing with the rest of the repo, the FTOs are meant to be a smaller, step by step situation. You can open a new PR once you're done with this to make more updates if you'd like! |
@rexagod I think that I'm thinking this is sufficient, and we don't need to add the 2nd way. I originally thought it "evened them out" but now I just think its unnecessary. Do you think it's ok to proceed with just |
Sure, we can definitely proceed with this and adding an appropriate comment at the same time should suffice the user's understanding of this feature. 👍 |
Ok cool, you're already a reviewer on my PR but i'll ping you again there for final review soon @rexagod |
closed via #229 |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update: In order to remove support for the deprecated
which
method, we'll be replacing it by thekey
method, while making some other appropriate changes as well. The steps are as follows.Replace the following key map values to comply with the
key
method, i.e., with the keymap provided below it.Leaflet.DistortableImage/src/edit/DistortableImage.Edit.js
Lines 7 to 22 in b84229e
which
method with thekey
one as follows.Leaflet.DistortableImage/src/edit/DistortableImage.Edit.js
Line 203 in b84229e
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
The text was updated successfully, but these errors were encountered: