Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded main images are displayed oddly #596

Closed
jywarren opened this issue Aug 14, 2020 · 9 comments · Fixed by #612
Closed

Uploaded main images are displayed oddly #596

jywarren opened this issue Aug 14, 2020 · 9 comments · Fixed by #612

Comments

@jywarren
Copy link
Member

On plots2, (publiclab/plots2#8297 in gitpod), I uploaded a main image but it displayed a bit weird. I'm wondering what the best way to organize the buttons and image is after upload?

Screen Shot 2020-08-14 at 5 58 45 PM

Love to hear your thoughts!

@cypherean
Copy link
Contributor

I tested it out in gitpod too and the main image box looked fine before uploading the image but changed after uploading the image
imgtrue
img

@sagarpreet-chadha
Copy link
Contributor

@publiclab/editor team, would anyone want to take a look at this, seems like a CSS fix that we need to do. Thanks in advance 🎉 💯

@daemon1024
Copy link
Member

daemon1024 commented Sep 6, 2020

Is this issue open to work on?

I was trying to recreate the issue but when I tested it out on gitpod as well as local but it seemed to get stuck at 100% progress bar. (It logs 405 in live-server i.e. Method not Allowed)

image

@sagarpreet-chadha
Copy link
Contributor

You can try reproducing this on publiclab.org then, if this issue still persists then you can take forward and solve it 😄 . Thanks 💯

@daemon1024
Copy link
Member

@sagarpreet-chadha I can reproduce it on publiclab.org.I thing i have the solution to it but I am unable to figure out how do I test it out after fixing it due to the problem I mentioned in the previous comment?

@sagarpreet-chadha
Copy link
Contributor

Did you try running this project locally?

@daemon1024
Copy link
Member

@sagarpreet-chadha i just found how to test image-upload ( https://github.com/publiclab/PublicLab.Editor#creating-a-mock-server ), I am trying this now

@daemon1024
Copy link
Member

@sagarpreet-chadha it works :) can you review the PR?

@jywarren
Copy link
Member Author

Thank you so much for your help on this!!! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants