Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Page wiki links point to wrong address #2204

Closed
grvsachdeva opened this issue Feb 2, 2018 · 3 comments
Closed

Tag Page wiki links point to wrong address #2204

grvsachdeva opened this issue Feb 2, 2018 · 3 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@grvsachdeva
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process

Please describe the problem

The new buttons on tag pages go to https://publiclab.org/wiki/#{params[:id]} instead of, for example, https://publiclab.org/wiki/spectral-workbench

See this at https://publiclab.org/tag/spectral-workbench

Solution

Replace this statement

<% if @wiki.latest.render_body.split('</p>').length > 2 %><a class="btn btn-lg btn-default" href="/wiki/#{params[:id]}">Learn more on the wiki page</a><% end %>

with

<% if @wiki.latest.render_body.split('</p>').length > 2 %><a class="btn btn-lg btn-default" href="/wiki/<%= params[:id] %>">Learn more on the wiki page</a><% end %>

📋 Step by Step

🙋‍♀️ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💾 Commit your changes

🔀 Start a Pull Request.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

@grvsachdeva grvsachdeva added bug the issue is regarding one of our programs which faces problems when a certain task is executed first-timers-only They need to be well-formatted using the First-timers_Issue_Template. labels Feb 2, 2018
@Souravirus
Copy link
Member

@Gauravano I want to fix this. Please assign this to me.

@grvsachdeva
Copy link
Member Author

Hey @Souravirus, that's great

@Souravirus
Copy link
Member

#2211 Please review this pr @Gauravano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

No branches or pull requests

2 participants