Deprecate DrupalFile and DrupalUpload tables and remove associated code to simplify codebase

[jywarren]

As part of the #956 work, we should move the records for all DrupalFile entries into the node revision body. This will be similar to #4072, where we're getting rid of needlessly customized infrastructure and database tables, and just building the content into the node body content.

So we'd run a migration that'd run on each node, which would fetch node.files and for each one, add a link to the bottom of the node content, maybe in the format:

* https://...link here
* https://...link here
* https://...link here

This will allow us to remove these files:

https://github.com/publiclab/plots2/blob/master/app/models/drupal_file.rb

https://github.com/publiclab/plots2/blob/master/app/models/drupal_upload.rb

And make a migration to drop the corresponding tables.

We'd also get rid of these lines:

https://github.com/publiclab/plots2/blob/master/app/models/node.rb#L79

plots2/app/models/node.rb

Lines 228 to 230 in 1ee4509

	def files
	drupal_files
	end

We'd love help with this!

[jywarren]

Added to GCI!

[jonxuxu]

So is each node in this case similar to a Map Node? Sorry I'm unfamiliar with plots2 architecture.

So we'd run a migration that'd run on each node, which would fetch node.files and for each one, add a link to the bottom of the node content

^ Also does this mean looking at the file characteristic of each node, getting the url and pasting it on the bottom of the node document? Not really sure what's required and if this should be done automated.

[manishaag7]

Can I work on this ?

[toshitapandey]

Hey @TildaDares, @jywarren!
Is this issue still open, if yes, is it okay if I pick it up?

[jywarren]

Hello, yes you can, thank you! Can we help you get oriented a bit? I wonder if @anirudhprabhakaran3 is able to make some suggestions? Please note @anirudhprabhakaran3 has begun this project already in #11387 and perhaps that is already complete, but the deletion of the records afterwards is not yet complete?

[anirudhprabhakaran3]

Hi! Yes, you're right. #11387 takes care of the migration of all data, but the actual deletion and dropping of the table are left. @toshitapandey, you can go ahead and create a PR for dropping the corresponding tables, and removing any reference to those tables in the codebase. Thank you, and sorry for the late response!