-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change function t to translation in app/views/notes/_coauthored_notes.html.erb #6754
Comments
I want to take this one. |
@kamal-kaur04 Great! Go ahead. |
Is this issue still open? I would like to take it up in that case. |
@jywarren @cesswairimu It looks like the fix for this was merged into someone else's fork, and not publiclab. |
Aha, indeed, @kamal-kaur04 can you open a new PR from your branch to |
This issue is open! |
Hello, |
@nstjean I apologize for being inactive. I didn't know that this is not merged in Public Lab repo. Can I open a pull request now for this issue? |
@kamal-kaur04 Go ahead! |
Thank you @nstjean |
@kamal-kaur04 Can you share some information on that? What are you doing when you get the errors? What do the errors say? |
@nstjean this issue is already been solved, I think thats why I was getting errors. |
@kamal-kaur04 Ahhh, I see, sorry! Not sure where that change was made, I don't see a link here. I did want to mention however that the errors you were getting were not because of that. It looks like you were trying to commit changes directly to the public lab repository, which will give you errors because you don't have access for that. You will have to fork the repository to your own copy first next time, then make changes and save to your own fork. |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file _coauthored_notes.html.erb in the
https://github.com/publiclab/plots2
repository (press the little pen Icon) and edit the line as shown below.See this page for some help in taking your first steps!
Below are the lines where we have to make changes change t() to translation():
plots2/app/views/notes/_coauthored_notes.html.erb
Line 14 in c7d8fe5
plots2/app/views/notes/_coauthored_notes.html.erb
Line 15 in c7d8fe5
plots2/app/views/notes/_coauthored_notes.html.erb
Line 16 in c7d8fe5
plots2/app/views/notes/_coauthored_notes.html.erb
Line 18 in c7d8fe5
plots2/app/views/notes/_coauthored_notes.html.erb
Line 31 in c7d8fe5
https://github.com/publiclab/plots2/blob/c7d8fe5ed09ac4df932e9309ceb44621e6091aeb/app/view
s/notes/_coauthored_notes.html.erb#L34
plots2/app/views/notes/_coauthored_notes.html.erb
Line 51 in c7d8fe5
plots2/app/views/notes/_coauthored_notes.html.erb
Line 55 in c7d8fe5
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
The text was updated successfully, but these errors were encountered: