Add disabling SIGPIPE per socket...

...where available. For now, that's only MacOS, but should be
"expandable" to BSDs, we're just not sure which ones.

Author: vveljko

freertos/pubnub_internal.h

@@ -37,6 +37,10 @@
 #define SOCKET_INVALID FREERTOS_INVALID_SOCKET
 
 
+/* FreeRTOS+TCP never raises SIGPIPE, so, we're good. */
+#define socket_disable_SIGPIPE(socket)
+
+
 typedef Socket_t pb_socket_t;
 
 /** The Pubnub FreeRTOS context */

lib/sockets/pbpal_resolv_and_connect_sockets.c

@@ -116,6 +116,7 @@ enum pbpal_resolv_n_connect_result pbpal_resolv_and_connect(pubnub_t *pb)
         }
 
         socket_set_rcv_timeout(pb->pal.socket, pb->transaction_timeout_ms);
+        socket_disable_SIGPIPE(pb->pal.socket);
 
         return error ? pbpal_connect_wouldblock : pbpal_connect_success;
     }

posix/pubnub_internal.h

@@ -1,6 +1,6 @@
 /* -*- c-file-style:"stroustrup"; indent-tabs-mode: nil -*- */
 #if !defined INC_PUBNUB_INTERNAL
-#define      INC_PUBNUB_INTERNAL
+#define INC_PUBNUB_INTERNAL
 
 
 #include <unistd.h>
@@ -24,12 +24,14 @@ typedef int pb_socket_t;
 #define socket_send(socket, buf, len) send((socket), (buf), (len), 0)
 #endif
 
-#define socket_recv(socket, buf, len, flags) recv((socket), (buf), (len), (flags))
+#define socket_recv(socket, buf, len, flags)                                   \
+    recv((socket), (buf), (len), (flags))
 
-/* Treating `EINPROGRESS` the same as `EWOULDBLOCK` isn't 
+/* Treating `EINPROGRESS` the same as `EWOULDBLOCK` isn't
    the greatest solution, but it is good for now.
 */
-#define socket_would_block() ((errno == EAGAIN) ||(errno == EWOULDBLOCK) || (errno == EINPROGRESS))
+#define socket_would_block()                                                   \
+    ((errno == EAGAIN) || (errno == EWOULDBLOCK) || (errno == EINPROGRESS))
 
 #define socket_timed_out() (errno == ETIMEDOUT)
 
@@ -38,16 +40,35 @@ typedef int pb_socket_t;
 #define SOCKET_INVALID -1
 #define SOCKET_ERROR -1
 
-/* Maybe we could use `getsockopt(socket_fd, SOL_SOCKET, SO_ERROR, &error, &len)`,
-    but, its utility is questionable, so probably test extensively to see if it 
-    really works for us.
+/* Maybe we could use `getsockopt(socket_fd, SOL_SOCKET, SO_ERROR, &error,
+   &len)`, but, its utility is questionable, so probably test extensively to see
+   if it really works for us.
     */
 #define socket_is_connected(socket) true
 
-#define socket_set_rcv_timeout(socket, milliseconds) do {                           \
-    struct timeval M_tm = { (milliseconds)/1000, ((milliseconds)%1000) * 1000 };    \
-    setsockopt((socket), SOL_SOCKET, SO_RCVTIMEO, (char*)&M_tm, sizeof M_tm);       \
-    } while(0)
+#define socket_set_rcv_timeout(socket, milliseconds)                              \
+    do {                                                                          \
+        struct timeval M_tm = { (milliseconds) / 1000,                            \
+                                ((milliseconds) % 1000) * 1000 };                 \
+        setsockopt((socket), SOL_SOCKET, SO_RCVTIMEO, (char*)&M_tm, sizeof M_tm); \
+    } while (0)
+
+
+#if __APPLE__
+/* Actually, BSD in general provides SO_NOSIGPIPE, but we don't know
+   what's the status of this support across various BSDs... So, for
+   now, we only do this for MacOS.
+*/
+#define socket_disable_SIGPIPE(socket)                                             \
+    do {                                                                           \
+        int on = 1;                                                                \
+        if (setsockopt(socket, SOL_SOCKET, SO_NOSIGPIPE, &on, sizeof(on)) == -1) { \
+            PUBNUB_LOG_WARNING("Failed to set SO_NOSIGPIPE, errno=%d\n", errno);   \
+        }                                                                          \
+    } while (0)
+#else
+#define socket_disable_SIGPIPE(socket)
+#endif
 
 
 /** The Pubnub POSIX context */
@@ -66,5 +87,4 @@ struct pubnub_pal {
 #include "core/pubnub_internal_common.h"
 
 
-
 #endif /* !defined INC_PUBNUB_INTERNAL */

windows/pubnub_internal.h

@@ -37,6 +37,11 @@ int socket_platform_init(void);
     setsockopt((socket), SOL_SOCKET, SO_RCVTIMEO, (char*)&M_tm, sizeof M_tm);   \
     } while(0)
 
+
+/* Winsock never raises SIGPIPE, so, we're good. */
+#define socket_disable_SIGPIPE(socket)
+
+
 /** The Pubnub Windows context */
 struct pubnub_pal {
     pb_socket_t socket;