Updated PubNub Js sdk containing membership type. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
kleewho,
wkal-pubnub and
jguz-pubnub
as code owners
marcin-cebo
force-pushed
the
mc/membrshipType_in_KMP_core2
branch
from
3e3b6c3 to
8b2a961
Compare
wkal-pubnub
reviewed
Dec 19, 2024
Comment on lines
723
to
732
| this.include = createJsObject<PubNubJs.MembershipIncludeOptions> { | ||
| this.customFields = include.includeCustom | ||
| this.totalCount = include.includeTotalCount | ||
| this.channelFields = include.includeChannel | ||
| this.customChannelFields = include.includeChannelCustom | ||
| this.channelTypeField = include.includeChannelType | ||
| this.channelStatusField = include.includeChannelStatus | ||
| this.statusField = include.includeStatus | ||
| this.typeField = include.includeType | ||
| } |
There was a problem hiding this comment.
perhaps we could extract this into a function like MembershipInclude.toMembershipIncludeOptions() if it's used in a few places
wkal-pubnub
reviewed
Dec 19, 2024
Comment on lines
1048
to
1057
| this.include = createJsObject<PubNubJs.IncludeOptions> { | ||
| this.totalCount = include.includeTotalCount | ||
| this.customFields = include.includeCustom | ||
| this.UUIDFields = include.includeUser | ||
| this.customUUIDFields = include.includeUserCustom | ||
| this.UUIDTypeField = include.includeUserType | ||
| this.UUIDStatusField = include.includeUserStatus | ||
| this.statusField = include.includeStatus | ||
| this.typeField = include.includeType | ||
| } |
There was a problem hiding this comment.
same - extract to a function?
In KMP js implemented new Memberships and ChannelMembers methods containing possibility to specify membership type and all optional data returned by API using include parameters.
marcin-cebo
force-pushed
the
mc/membrshipType_in_KMP_core2
branch
from
8b2a961 to
d823d6d
Compare
wkal-pubnub
approved these changes
Jan 3, 2025
|
@pubnub-release-bot release kotlin as v10.3.3 |
|
@pubnub-release-bot release kotlin as v10.3.3 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Added validation for Leave and Heartbeat
Added validation for Leave and Heartbeat to ensure user receives an error when providing empty strings for channels or groups.
refactor: Internal refactor