Pluralize getMessageActions typo #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
approved these changes
Jan 8, 2025
marcin-cebo
approved these changes
Jan 9, 2025
| @@ -17,7 +17,7 @@ class RemoveMessageAction extends Endpoint | |||
| protected int $endpointConnectTimeout; | |||
| protected int $endpointRequestTimeout; | |||
| protected string $endpointHttpMethod = PNHttpMethod::DELETE; | |||
| protected int $endpointOperationType = PNOperationType::PNGetMessageActionOperation; | |||
| protected int $endpointOperationType = PNOperationType::PNRemoveMessageActionOperation; | |||
There was a problem hiding this comment.
yes. typical copy paste missed
src/PubNub/PubNub.php
Outdated
| @@ -56,6 +57,7 @@ | |||
| use Psr\Log\LoggerAwareInterface; | |||
| use Psr\Log\NullLogger; | |||
| use PubNub\Endpoints\FileSharing\{SendFile, DeleteFile, DownloadFile, GetFileDownloadUrl, ListFiles}; | |||
| use PubNub\Endpoints\MessageActions\GetMessageAction; | |||
There was a problem hiding this comment.
Why this is not next to:
use PubNub\Endpoints\MessageActions\GetMessageActions;
?
There was a problem hiding this comment.
autoimport messed this one up. fixed in new commit
marcin-cebo
approved these changes
Jan 9, 2025
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
techwritermat
approved these changes
Jan 28, 2025
seba-aln
force-pushed
the
feat/add-support-for-message-reactions
branch
2 times, most recently
from
c9e2224 to
c42f8d3
Compare
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Pluralize getMessageActions and fix typing