Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning " > pug-loader@2.4.0" has incorrect peer dependency "pug@^2.0.0". #126

Open
nypinstripes opened this issue Jun 11, 2020 · 6 comments · May be fixed by #128
Open

warning " > pug-loader@2.4.0" has incorrect peer dependency "pug@^2.0.0". #126

nypinstripes opened this issue Jun 11, 2020 · 6 comments · May be fixed by #128

Comments

@nypinstripes
Copy link

Hey,

Library still works great with pug@3.0.0, just wanted to see if we can get the peer dependency bumped to remove the warning, cheers.

@sokra
@TimothyGu
@simon04
@nypinstripes
Copy link
Author

nypinstripes commented Jul 22, 2020 •
edited
Loading

@mekwall @leenty @bpiwowar @ForbesLindesay Hi, library still working good under pug@3.0.0 just wanted to see if we can get the peer dependency bumped to remove the warning, cheers.

@mekwall mekwall linked a pull request Jul 31, 2020 that will close this issue
Open
@noahbrenner
Copy link

@ForbesLindesay What do you think of the linked PR for fixing this issue? It would be great to have pug@3 officially supported.

@webdiscus
Copy link

Hallo @sokra,

do You can please update in peerDependencies "pug": "^3.0.0" or merge the PR von @mekwall b0b76c0

We all, 100500 people need your official support to avoid the Warning.
Könntest Du bitte nur eine Zeile anpassen?

LG from Köln

@webdiscus
Copy link

Up!

phacks added a commit to orbit-love/pug-loader that referenced this issue Jan 14, 2021
@phacks
Update peerDependency to support pug@3
65d834e 
pugjs#126
@jdneo jdneo mentioned this issue Mar 3, 2021
Merged
@phanect
Copy link

phanect commented Mar 11, 2021 •
edited
Loading

Now this issue causes a dependency error on npm install and prevents package installation.
This is caused by a breaking change in npm v7.

$ cat package.json
{
  // ...
  "dependencies": {
    // ...
    "pug": "^3.0.0",
    "pug-loader": "^2.4.0",
  },
  // ...
}

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: ***@1.0.0
npm ERR! Found: pug@3.0.2
npm ERR! node_modules/pug
npm ERR!   pug@"^3.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer pug@"^2.0.0" from pug-loader@2.4.0
npm ERR! node_modules/pug-loader
npm ERR!   dev pug-loader@"^2.4.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/jogawa/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jogawa/.npm/_logs/2021-03-11T06_56_38_776Z-debug.log

Workaround: add --legacy-peer-deps option

$ npm install --legacy-peer-deps

Update: I switched to pug-plain-loader since pug-loader seems unmaintained.

@webdiscus
Copy link

For all who want use the pug-loader compatible with Webpack 5 and Pug 3 propose try to use the alternative pug-loader
This pug loader support webpack aliases, watching of changes in all dependencies and is many time faster.

@Jose-Matsuda Jose-Matsuda mentioned this issue Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change pug peer dependency to allow 2.0.0 and later
4 participants
@phanect @nypinstripes @webdiscus @noahbrenner