-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't support async functions #67
Comments
Hi there! I'm not quite sure if you're joking or not, but I'm going to respond to your comment as if you're not. (1) Are you implying that a function is a primitive value? Rest assured, functions are objects. (2) If your definition of "object" is actually "object literal" (or "Plain Old JavaScript Object") and what you are saying is that this library should only concern itself with such, please remember that: If what you are implying is that this library should only compute hashes on object literal, and only based on their identifier, then I must inform you that this library is far more intelligent and wider reaching than that. In case your comment is a joke, well, here's a beer emoji: 🍺 |
Consider:
This breaks usage with untranspiled code (node v7.4.0 and above as well as any ES2017+ compatible browser)
I've added a PR: #68
The text was updated successfully, but these errors were encountered: