-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Recent dataset list on the main page is not reflective of new dataset #542
Comments
For reference: there were 17 works published this year (2023) and we only show 5 in the recent works page. The sort is done by year so there is no easy way to determine which one is more recent of those 17 works. |
Is there a published metadata date that we can use? |
We can use either created_at or updated_at, which exist on the database record but not in the Datacite record. For the referenced data set, these are:
I'm going to index them both so we can try out which of these works better in the UI. |
Great. I suspect created date makes the most sense |
Done |
@astrochun Asked us to look into why the dataset he mentioned isn't on the front page.
All of which are more recent than 17 Nov 2023. Do we instead need some combination of "publication date" and "created_at"? |
@bess perhaps. The issue is that we did not migrate the data in chronological order and had to publish new datasets. A lot of those aren't recent datasets but from a few years back. I know this is a challenging one to fix since the metadata is a bit limited. If we can filter out those that have a publication date on or before 2022, that should capture more of the recent datasets. I think once we have more datasets, this will resolve itself. |
Another idea: Maybe we exclude anything that was migrated? |
Here's my two cents: "recently published" should sort in reverse-chronological order by the date of first issue (not update/edit, and not migration); and once we get past the migration phase, I don't expect much confusion about what recently went into PDC vs. what was recently published for the first time. |
I talked to @matthewjchandler on slack and after discussion he now agrees we should sort by the pdc |
UPDATE: Sounds like we don't yet have quite the right definition of what should be on the Recently Published feed. Working with @astrochun and @matthewjchandler to figure out what that should be.
On Friday, December 8, we published a new dataset in PDC:
However, on the main Discovery page this does not show up under "Recently published".
@hectorcorrea points out that the sorting is done by perhaps year, so it's not capturing the proper order between each dataset.
Acceptance criteria
created_at
timestamp from PDC DescribeThe text was updated successfully, but these errors were encountered: