-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mirror flag when syncing rpm repositories #212
Conversation
Btw I also considered if it would be better to use |
We use |
@mdellweg thanks for suggestion, I modified PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daviddavis do you think, we need a changelog here?
I don't see the harm in adding a changelog. It's good to always call out new additions. That said, I have no objection to not having a changelog either. |
@mdellweg If you prefer to have changelog entry, I can easily add one. However if I understand the |
You could just use this PR number (ie |
@daviddavis ok, added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
[noissue]