Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container roles #468

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Container roles #468

merged 1 commit into from
Mar 17, 2022

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Feb 4, 2022

We probably want some tests for this...

depends on #465

@mdellweg mdellweg force-pushed the container_roles branch 2 times, most recently from 8420d4e to b93889a Compare February 4, 2022 13:23
@mdellweg mdellweg marked this pull request as ready for review February 23, 2022 12:22
@mdellweg mdellweg added this to the 0.14.0 milestone Feb 23, 2022
@mdellweg mdellweg enabled auto-merge (rebase) February 23, 2022 13:36
@mdellweg mdellweg force-pushed the container_roles branch 2 times, most recently from b11f109 to 713f123 Compare March 2, 2022 10:03
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see tests for this before we merge it, please!

@ggainey ggainey modified the milestones: 0.14.0, 0.15.0 Mar 2, 2022
@mdellweg mdellweg requested a review from ggainey March 17, 2022 08:09
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests - lg2m!

@mdellweg mdellweg merged commit af9c919 into pulp:main Mar 17, 2022
@mdellweg mdellweg deleted the container_roles branch March 17, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants