Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync can fail if multiple collections share a dependency #1429

Open
gerrod3 opened this issue Apr 21, 2023 · 0 comments
Open

Sync can fail if multiple collections share a dependency #1429

gerrod3 opened this issue Apr 21, 2023 · 0 comments

Comments

@gerrod3
Copy link
Contributor

gerrod3 commented Apr 21, 2023

Version
<=0.17

Describe the bug
Dependency sync with multiple collections sharing a dependency can cause sync failures if the upstream server has rate-limiting. While the shared dependency will only be downloaded once, the metadata for that collection will be fetched multiple times on V2 syncs and can cause a rate-limit. The V2 sync machinery should remember the metadata for collections it has already visited to avoid this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant