Problem with jsonchema dependency on pulp-container 2.14

[Odilhao]

Version

Pulpcore 3.21
pulp_container 2.14

Describe the bug
The jsonschema version required by pulp_container conflicts with the version required by pulp-ansible

pulp-container requires ~=4.4
Pulp-ansible requires >=4.9,<4.10

This also conflicts with pulp-rpm that requires jsonschema~=4.6

To Reproduce
I'm branching the rpm packages for 3.21, it's not reproducible yet.

Expected behavior
All packages to have at least the same jsonchema version as dependency or having a more flexible dependency requirement.

Additional context

https://github.com/pulp/pulp_container/blob/2.14.0/requirements.txt#L6
https://github.com/pulp/pulp_rpm/blob/3.18.3/requirements.txt#L3
https://github.com/pulp/pulp_ansible/blob/0.15.0/requirements.txt#L4

[lubosmj]

This is a duplicate of #772.

[fao89]

This is a duplicate of #772.

not duplicate, it happened again!

[ipanova]

@Odilhao I see the discrepancy you're pointing out, however best what we can do is write guidelines on how to declare dependencies https://github.com/pulp/pulpcore/blob/main/docs/plugins/plugin-writer/concepts/index.rst#declaring-dependencies . Some plugins are out of our control so we cannot ensure every plugin uses same dep.version.
Based on what you have reported the 4.9 dependency requirement should be satisfied by all 3 plugins where:

pulp-container requires ~=4.4 translates to anything >=4.4,<5
pulp-ansible requires >=4.9,<4.10
pulp-rpm requires jsonschema~=4.6 ranslates to anything >=4.6,<5

Do you see a different behavior?

[Odilhao]

@Odilhao I see the discrepancy you're pointing out, however best what we can do is write guidelines on how to declare dependencies https://github.com/pulp/pulpcore/blob/main/docs/plugins/plugin-writer/concepts/index.rst#declaring-dependencies . Some plugins are out of our control so we cannot ensure every plugin uses same dep.version.

Based on what you have reported the 4.9 dependency requirement should be satisfied by all 3 plugins where:

pulp-container requires ~=4.4 translates to anything >=4.4,<5

pulp-ansible requires >=4.9,<4.10

pulp-rpm requires jsonschema~=4.6 ranslates to anything >=4.6,<5

Do you see a different behavior?

This is the behavior that I expect, I already did a PR last week to publish the rpms.

theforeman/pulpcore-packaging#587

I saw that we are pining cryptography, can we keep that one without a version pin? AFAIK we ship one old stable version that don't need rust, it's 3.x I think.

[ipanova]

Have you seen these changes?
pulp/pulpcore@eb0f4fe
https://github.com/pulp/pulpcore/blob/main/docs/plugins/plugin-writer/concepts/index.rst#declaring-dependencies

Given that you opened this issue, that is your expectation of the fix? Based on my comment - I do not see any current problem with dependencies.

[ipanova]

I am unsure what is required to be done in this request, unassigning.

[dkliban]

pulp_container needs to stop using ~= in the requirements.txt.

[ipanova]

In the next release we will switch to >=x,<=y format @Odilhao

[ipanova]

2.14.2 is out

[tjmullicani]

pulp_ansible has been updated to use jsonschema up to v4.17 (required by ansible-lint v6.8.7, which is a dependency for galaxy_importer v0.4.6). The current pulp_container requirement of jsonschema <4.17 will cause errors when installing together with pulp_ansible.

[ipanova]

@tjmullicani thanks for pointing out. the jsonschema dep was updated on the main brain of pulp_ansible, we will make sure that main brain of pulp_container includes 3.17