Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-next] Deleting files via tree-view doesn't work #1107

Closed
savetheclocktower opened this issue Sep 28, 2024 · 2 comments · Fixed by #1109
Closed

[pulsar-next] Deleting files via tree-view doesn't work #1107

savetheclocktower opened this issue Sep 28, 2024 · 2 comments · Fixed by #1109
Assignees
@savetheclocktower
Labels
bug Something isn't working pulsar-next Related to the version of Pulsar that runs on the latest Electron

Comments

@savetheclocktower
Copy link
Contributor

We were using a deprecated function, so I think this is just a modernization task. Logging it so I don't forget about it.
@savetheclocktower savetheclocktower converted this from a draft issue Sep 28, 2024
@savetheclocktower savetheclocktower changed the title Deleting files via tree-view doesn't work [pulsar-next] Deleting files via tree-view doesn't work Sep 28, 2024
@savetheclocktower savetheclocktower added pulsar-next Related to the version of Pulsar that runs on the latest Electron bug Something isn't working labels Sep 28, 2024
@savetheclocktower savetheclocktower self-assigned this Sep 28, 2024
@savetheclocktower
Copy link
Contributor Author

savetheclocktower commented Sep 28, 2024 •
edited
Loading

The fix is pretty simple and is present on the updated-latest-electron branch. It can also be backported to current Pulsar.

@savetheclocktower
Copy link
Contributor Author

Created #1109 to fix this in current Pulsar.

@savetheclocktower savetheclocktower linked a pull request Sep 29, 2024 that will close this issue
[tree-view] Remove deprecated usage of shell.moveItemToTrash #1109
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savetheclocktower savetheclocktower

Labels
bug Something isn't working pulsar-next Related to the version of Pulsar that runs on the latest Electron
Projects
Pulsar on latest Electron
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tree-view] Remove deprecated usage of shell.moveItemToTrash savetheclocktower/pulsar
1 participant
@savetheclocktower