Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symbols-view] “Go to Declaration” command should fall back to buffer symbols if no project-wide symbol provider is available #914

Open
1 task done
savetheclocktower opened this issue Feb 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@savetheclocktower
Copy link
Contributor

Have you checked for existing feature requests?

  • Completed

Summary

Lots of users don't even realize that the Symbols View: Go To Declaration command exists, and others probably noticed that it doesn't seem to do anything. That's because it depends upon the ability to generate project-wide symbols. Currently, that's something they'd need to generate a TAGS file for with ctags, or else use pulsar-ide-typescript-alpha or one of the handful of other experimental pulsar-ide- packages.

But if the command is going to do nothing in those scenarios, there's no reason why it couldn't instead just try to resolve the symbol under the cursor by doing a buffer-wide symbol search instead of a project-wide symbol search. It'd have more value than it does now.

What benefits does this feature provide?

Trains people to expect Go To Declaration to do something. Everyone should use that command once in a while; it's wonderful.

Any alternatives?

It should still be a goal of ours to make it so that more users have set up their environments so that project-wide symbol search is an option! That'd happen by increasing awareness of IDE backend packages and bringing them up to date. But in the meantime, this enhancement doesn't have a downside.

Other examples:

No response

@savetheclocktower savetheclocktower added the enhancement New feature or request label Feb 9, 2024
@savetheclocktower savetheclocktower self-assigned this Feb 9, 2024
@savetheclocktower
Copy link
Contributor Author

This is on my to-do list, but I'm capturing it in an issue since I wasn't able to get to it in the last month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant