Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors code on comment should not be printed #1228

Closed
notdodo opened this issue Jul 16, 2024 · 7 comments
Closed

Colors code on comment should not be printed #1228

notdodo opened this issue Jul 16, 2024 · 7 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@notdodo
Copy link

notdodo commented Jul 16, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The action allows to enable color with auto (default), raw, never and always.
The action allows to show a comment-on-pr for the preview.

It's not possible to enable colors only for the GHA output:

  1. enable color: always
  2. the preview/output in the "Actions" github page is shown with colors
  3. the output in the comment of the PR contains color and escape codes

Should be fair to allow colors only for the "Actions" pulumi output and not in the comment of the PR.

Affected area/feature

Pulumi output/colors

@notdodo notdodo added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 16, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Jul 17, 2024
@justinvp
Copy link
Member

Thanks for the suggestion!

@notdodo
Copy link
Author

notdodo commented Jul 17, 2024

#859

@notdodo
Copy link
Author

notdodo commented Jul 20, 2024

#1231

@tgummerer tgummerer self-assigned this Jul 25, 2024
@tgummerer tgummerer added the resolution/fixed This issue was fixed label Jul 25, 2024
@tgummerer
Copy link
Contributor

#1231 has been merged and released, so I think this can be closed. Please let us know if this is still not working as desired.

@neilprosser
Copy link

Related to this. I'm seeing color-related characters in the GitHub step summary when color: always and comment-on-summary: true are both set.

@tgummerer
Copy link
Contributor

@neilprosser can you please open a new issue for that if you're still seeing that in the latest release? This will allow us to keep tracking that, a comment in a closed issue is likely to be lost.

@neilprosser
Copy link

No problem. Done and created #1248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants