allow PR comment from non-PR events using comment-on-pr-number
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi again @bennettp123! Thanks for opening this PR. Just a friendly reminder, add a line to the CHANGELOG with your PR for this bug fix. 👍🏻 Great catch! |
This was referenced Dec 27, 2022
|
Tested in a personal repo:
|
|
Hi @RobbieMcKinstry, I've updated the CHANGELOG, and I've tested it in a personal repo, so I'm happy for it to be merged. Let me know if there's anything else you need 😄 |
bennettp123
force-pushed
the
fix/comment-on-pr-number-ignored-unless-event-type-is-pullrequest
branch
from
ecb8033 to
84bdc62
Compare
bennettp123
force-pushed
the
fix/comment-on-pr-number-ignored-unless-event-type-is-pullrequest
branch
from
de28bb1 to
8a752e2
Compare
|
Looks like some unwanted changes crept in while merging changes from master. I've rebased instead, and fixed up the conflicts manually. |
RobbieMcKinstry
approved these changes
Jan 23, 2023
|
Hey Bennett, I apologize for the delay in getting this merge. You made my life easy by making your contribution straightforward to review! Thanks very much! ❤️ |
bennettp123
deleted the
fix/comment-on-pr-number-ignored-unless-event-type-is-pullrequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
comment-on-pr-numberto be used to comment on a PR, even when not called from apull_requestevent.Fixes #802